Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verse block: fix white space #19173

Merged
merged 1 commit into from Dec 17, 2019
Merged

Verse block: fix white space #19173

merged 1 commit into from Dec 17, 2019

Conversation

@ellatrix
Copy link
Member

ellatrix commented Dec 16, 2019

Description

Fixes #19083. Since #18372, the verse block uses character line breaks instead of element line breaks. Unfortunately, I seem to have missed correcting the styles on the front end to be pre-style.

How has this been tested?

Create a verse block with two lines. View the front end. There should be two lines.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@mcsf
mcsf approved these changes Dec 16, 2019
Copy link
Contributor

mcsf left a comment

I'm surprised we both missed this 😓 — LGTM!

@ellatrix ellatrix merged commit 164b847 into master Dec 17, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@ellatrix ellatrix deleted the fix/verse-white-space branch Dec 17, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.