Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nav block e2e tests #19189

Merged
merged 10 commits into from Dec 17, 2019
Merged

Add nav block e2e tests #19189

merged 10 commits into from Dec 17, 2019

Conversation

@talldan
Copy link
Contributor

talldan commented Dec 17, 2019

Description

This adds back the e2e tests that were originally merged in #18929, but then reverted in #19119 as they were causing failures.

I discovered that just before the original PR was merged some button text that the tests depend on was updated in #19105, which then caused them to fail. I've updated this text in 316bb1e.

As the original PR already had approval I don't think there's any need to wait for a review, I'll merge once the tests are passing.

@talldan talldan requested review from ajitbohra, gziolo, nerrad and ntwb as code owners Dec 17, 2019
@talldan talldan self-assigned this Dec 17, 2019
@talldan talldan merged commit fb261a7 into master Dec 17, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the add/nav-block-e2e-tests branch Dec 17, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.