Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for welcome guide #19195

Merged
merged 2 commits into from Dec 17, 2019
Merged

Adjustments for welcome guide #19195

merged 2 commits into from Dec 17, 2019

Conversation

@karmatosed
Copy link
Member

karmatosed commented Dec 17, 2019

  • Reduces header to have text on desktop on one line.
  • Reduces line-height on header and makes it number over px.
  • Tried to avoid widows but needs longer lasting solution.

Before

image

After

image

- Reduces header to have text on desktop on one line.
- Reduces line-height on header and makes it number over px.
- Tried to avoid widows but needs longer lasting solution.
@karmatosed karmatosed requested a review from talldan as a code owner Dec 17, 2019
Props @jasmussen for fix
@jasmussen jasmussen self-requested a review Dec 17, 2019
Copy link
Contributor

jasmussen left a comment

Thanks for working on this.

This is a small PR, which improves the situation:

welcome

I would suggest this window needs a fair bit of more love than just this one PR. The vertical alignment of the text jumps quite a bit between slides, and overall the layout could use a little massaging, perhaps even rephrasings. The icons in the SVGs also look squished in places, even if they aren't.

However because this is such an improvement over what's currently merged, it's good as an interim fix provided we do more polish!

@karmatosed

This comment has been minimized.

Copy link
Member Author

karmatosed commented Dec 17, 2019

I agree this needs deeper iterations as yes this is just a little plaster fix.

@karmatosed karmatosed merged commit 6f6412a into master Dec 17, 2019
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Errored
Details
@karmatosed karmatosed deleted the try/adjust-welcome branch Dec 17, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
@marco-firmo

This comment has been minimized.

Copy link

marco-firmo commented Jan 10, 2020

Hey, with the latest version of Gutenberg i found that problem:

TypeError: Cannot read property 'disableTips' of null
at ho (.../wp-content/plugins/gutenberg/build/edit-post/index.js:6:82642)
at je (.../wp-content/plugins/gutenberg/vendor/react-dom.min.b694e242.js:78:476)
at ph (.../wp-content/plugins/gutenberg/vendor/react-dom.min.b694e242.js:215:173)
at lh (.../wp-content/plugins/gutenberg/vendor/react-dom.min.b694e242.js:126:409)
at O (.../wp-content/plugins/gutenberg/vendor/react-dom.min.b694e242.js:121:71)
at ze (.../wp-content/plugins/gutenberg/vendor/react-dom.min.b694e242.js:118:14)
at .../wp-content/plugins/gutenberg/vendor/react-dom.min.b694e242.js:53:49
at unstable_runWithPriority (.../wp-content/plugins/gutenberg/vendor/react.min.0212dc62.js:26:340)
at Ma (.../wp-content/plugins/gutenberg/vendor/react-dom.min.b694e242.js:52:280)
at mg (.../wp-content/plugins/gutenberg/vendor/react-dom.min.b694e242.js:52:496)

My Wordpress Setup
WP_MAX_MEMORY_LIMIT: 1024M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_LOCAL_DEV: undefined
DB_CHARSET: utf8mb4
DB_COLLATE: undefined

extension: mysqli
server_version: 5.7.26
server_architecture: Windows NT 10.0 AMD64
httpd_software: Apache/2.4.39 (Win64) PHP/7.3.5
php_version: 7.3.5 64bit
php_sapi: apache2handler
max_input_variables: 10000
time_limit: 120
memory_limit: 1024M
max_input_time: 60
upload_max_size: 128M
php_post_max_size: 16M
curl_version: 7.64.0 OpenSSL/1.1.1b

My Plugin List:
Advanced Custom Fields Multilingual: version: 1.5.0, author: OnTheGoSystems
Advanced Custom Fields PRO: version: 5.8.7, author: Elliot Condon
Custom Post Type UI: version: 1.7.2, author: WebDevStudios
Disable Comments: version: 1.10.2, author: Samir Shah
ETT Blocks: version: 1.0.0, author: ETT SPA
Gutenberg: version: 7.2.0, author: Gutenberg Team
Hummingbird: version: 2.2.2, author: WPMU DEV
Regenerate Thumbnails: version: 3.1.2, author: Alex Mills (Viper007Bond)
WPML Media: version: 2.5.5, author: OnTheGoSystems
WPML Multilingual CMS: version: 4.3.6, author: OnTheGoSystems
WPML String Translation: version: 3.0.6, author: OnTheGoSystems
WPML Translation Management: version: 2.9.4, author: OnTheGoSystems

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Jan 10, 2020

This might be related to the nux deprecation cc @noisysocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.