Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Data: Remove unused forceRender argument #19206
This pull request seeks to remove an unused argument in the implementation of
In theory, the previous implementation could cause memory accumulation and/or extra load on garbage collection due to the initialization and subsequent destruction of the unused object references. The expected impact of this is not significant, but since this is a hot code path, it is worth the extra attention.
I expect this could have been lingering code from an earlier iteration of the hook, considering that this pattern is often used when forcing a render using the
Ensure unit tests pass: