Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused `blocks-font-size` classname #19208

Merged
merged 1 commit into from Dec 20, 2019
Merged

Conversation

@talldan
Copy link
Contributor

talldan commented Dec 18, 2019

Description

This is a very tiny PR that removes a classname blocks-font-sizes from the paragraph block's Text Settings panel.

The css for this classname seem to have been removed a while ago from the paragraph block, so removing it has no visual effect. The only usage was in an end-to-end test where it was used as part of a selector, but this was easily replaced with the font-size-picker classname.

How has this been tested?

  1. Add a paragraph block
  2. Try changing the font size
  3. Observe that the font size picker looks the same as it did previously

Types of changes

Non-breaking task

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@talldan talldan added the [Type] Task label Dec 18, 2019
@talldan talldan self-assigned this Dec 18, 2019
@talldan talldan mentioned this pull request Dec 18, 2019
2 of 6 tasks complete
Copy link
Contributor

draganescu left a comment

I have tested this. Initially I found the "default" setting to be missing but after a rebase everything was OK. All good codewise.

@draganescu draganescu merged commit 58fcf4d into master Dec 20, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@draganescu draganescu deleted the remove/unused-classname branch Dec 20, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.