Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: reposition on click #19268

Merged
merged 2 commits into from Dec 20, 2019
Merged

Popover: reposition on click #19268

merged 2 commits into from Dec 20, 2019

Conversation

@ellatrix
Copy link
Member

ellatrix commented Dec 20, 2019

Description

Currently, when opening or closing the sidebar for example, popovers only reposition after a delay. I've added a click listener to also refresh the popover positions because it might have changed the layout.

How has this been tested?

Create an image block. Focus the caption field so an inline toolbar pops up. Now open and close the sidebar a few times. Notice that there is a delay in repositioning the popover, which is now smooth with this PR.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@ellatrix ellatrix merged commit 7fcd745 into master Dec 20, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@ellatrix ellatrix deleted the fix/popover-reposition-click branch Dec 20, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.