Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: remove buffer options #19283

Merged
merged 1 commit into from Dec 20, 2019
Merged

Popover: remove buffer options #19283

merged 1 commit into from Dec 20, 2019

Conversation

@ellatrix
Copy link
Member

ellatrix commented Dec 20, 2019

Description

These options were added in #17867, but I realised recently that we could just use a margin. 馃檲
These options were not documented and not part of any WordPress release, so they are safe to remove.

How has this been tested?

Check the inline toolbar position for the image block. There should be some space between the caption text and the toolbar.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@ellatrix ellatrix force-pushed the remove/popover-buffer branch from 26e83cb to 01320e7 Dec 20, 2019
@ellatrix ellatrix merged commit 56cd1df into master Dec 20, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@ellatrix ellatrix deleted the remove/popover-buffer branch Dec 20, 2019
@@ -55,6 +55,7 @@ figcaption.block-editor-rich-text__editable [data-rich-text-placeholder]::before

.components-popover__content {
min-width: auto;
margin-bottom: 6px;

This comment has been minimized.

Copy link
@youknowriad

youknowriad Dec 20, 2019

Contributor

while this seem simpler, from a user's perspective, it's less obvious. I wonder if keeping the prop and make it work by adding a margin could be the best of both worlds. No urgency though, just a thought in case this becomes a common pattern.

This comment has been minimized.

Copy link
@ellatrix

ellatrix Dec 20, 2019

Author Member

From my experience with #18779, it does seem easier at first to have an option like this, but this option is way less flexible than CSS. In CSS you can adjust it based on classes etc. It's also something that's clearly styling and should ideally be done in CSS if possible.

@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.