Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide Accessibility: Change the aria-current expression to be a step instead of a boolean #19290

Merged
merged 2 commits into from Dec 21, 2019

Conversation

@MarcoZehe
Copy link
Contributor

MarcoZehe commented Dec 21, 2019

Description

Change the attribute value that is set for aria-current to be "step", not "true" or "false".

This is in accordance with the documentation of aria-current:

A step token used to indicate a link within a step indicator for a step-based process, where the link is visually styled to represent the current step.

How has this been tested?

Tested in StoryBook using NVDA and Firefox.

Screenshots

Types of changes

Enhancement.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
…instead of a boolean
@ellatrix

This comment has been minimized.

Copy link
Member

ellatrix commented Dec 21, 2019

Perhaps a link to the specification could be left as a comment above?

@MarcoZehe

This comment has been minimized.

Copy link
Contributor Author

MarcoZehe commented Dec 21, 2019

Perhaps a link to the specification could be left as a comment above?

Done, I updated the description.

@ellatrix

This comment has been minimized.

Copy link
Member

ellatrix commented Dec 21, 2019

@MarcoZehe Ah, I meant in the above the code adding aria-current. 😄 It might be nice as many developer are not very aware of what (some) aria- attributes do.

Copy link
Member

ellatrix left a comment

Perfect, thank you! ❤️

@MarcoZehe MarcoZehe merged commit 061dfb0 into master Dec 21, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@MarcoZehe MarcoZehe deleted the fix/UseAriaCurrentStep branch Dec 21, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.