Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dates alignments in the picker #19294

Conversation

@devdivdev
Copy link
Contributor

devdivdev commented Dec 21, 2019

Potential fix to #19228
By removing a negative margin, that probably was used to fix an issue but it's no longer needed after another recent change was made
I also added a basic storybook for the component.

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
Copy link
Member

jorgefilipecosta left a comment

Fixes the problem in my tests 👍 Thank you for your contribution!

@jorgefilipecosta jorgefilipecosta force-pushed the devdivdev:update/date-picker-dates-alignement-with-days branch 2 times, most recently from 1bb32c9 to b63e7c2 Dec 23, 2019
@devdivdev

This comment has been minimized.

Copy link
Contributor Author

devdivdev commented Dec 23, 2019

Seems like the unit test are failing because of React warnings @jorgefilipecosta on other related components

By removing a negative margin, that probably was used to fix an issue but it's no longer needed after another recent change was made
I also added a basic storybook for the component.
@jorgefilipecosta jorgefilipecosta force-pushed the devdivdev:update/date-picker-dates-alignement-with-days branch from b63e7c2 to 6e3ba5d Dec 23, 2019
@jorgefilipecosta jorgefilipecosta merged commit fb836a4 into WordPress:master Dec 23, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta

This comment has been minimized.

Copy link
Member

jorgefilipecosta commented Dec 23, 2019

Seems like the unit test are failing because of React warnings @jorgefilipecosta on other related components

It seems better to merge the fix without the story for now. I think the problem was in a component from an external library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.