Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IconButton and replace its usage with Button #19299

Merged
merged 2 commits into from Dec 24, 2019

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Dec 23, 2019

This PR replaces all usage of IconButton by Button in the project and deprecates the IconButton component.

testing instructions

  • Tests should pass.
@youknowriad

This comment has been minimized.

Copy link
Contributor Author

youknowriad commented Dec 23, 2019

Is this safe for mobile @hypest @Tug ? the Button component must support the icon prop here.

@@ -1,6 +1,7 @@
/**
* WordPress dependencies
*/
import deprecated from '@wordpress/deprecated';

This comment has been minimized.

Copy link
@gziolo

gziolo Dec 23, 2019

Member

I’m on mobile so I can’t do a proper check. Is README file removed? It should as our docs generator will still keep it exposed. Maybe we could remove the folder completely and put the file in deprecated subfolder?

This comment has been minimized.

Copy link
@youknowriad

youknowriad Dec 24, 2019

Author Contributor

Good call

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Dec 23, 2019

Nice one, I wasn’t sure in which direction you would go but seeing this PR, I admit I like it. We should follow up and make similar refactoring for the Toolbar components family 👍

@youknowriad youknowriad force-pushed the update/deprecate-icon-button branch from 50ebaca to 0899ee6 Dec 24, 2019
@youknowriad youknowriad merged commit 6740bd2 into master Dec 24, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the update/deprecate-icon-button branch Dec 24, 2019
@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Dec 24, 2019

Great one, thanks for wrangling it 💯

@diegohaz diegohaz mentioned this pull request Dec 26, 2019
6 of 6 tasks complete
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.