Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation mode: fix tabbing to title #19305

Merged
merged 2 commits into from Dec 23, 2019
Merged

Navigation mode: fix tabbing to title #19305

merged 2 commits into from Dec 23, 2019

Conversation

@ellatrix
Copy link
Member

ellatrix commented Dec 23, 2019

Description

Currently in navigation mode, reverse tabbing from the first block does not work correctly. It's supposed to focus the title, but right now it focusses the block appender, then the block wrapper, and then the title. Instead, we focus look at the tabbable element before the block (title element).

How has this been tested?

In navigation mode, pressing Shift+Tab from the first block should focus the title.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@ellatrix ellatrix merged commit e3d20fc into master Dec 23, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@ellatrix ellatrix deleted the fix/navigation-to-title branch Dec 23, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.