Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor edit post shortcuts to use the keyboard-shortcuts package #19320

Merged
merged 2 commits into from Dec 25, 2019

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Dec 24, 2019

I've also refactored the components that I touched to use useSelect/useDispatch.

I've noticed that the "sidebar toggle" shortcut is not working but that's on master too.

@youknowriad youknowriad requested review from ellatrix and talldan as code owners Dec 24, 2019
@youknowriad youknowriad self-assigned this Dec 24, 2019
@youknowriad youknowriad force-pushed the update/edit-post-shortcuts branch from e8b8841 to ed437ef Dec 24, 2019
@youknowriad youknowriad force-pushed the update/edit-post-shortcuts branch from ed437ef to 4abf7c6 Dec 25, 2019
@youknowriad youknowriad force-pushed the update/edit-post-shortcuts branch from 4abf7c6 to c47f1f4 Dec 25, 2019
@youknowriad youknowriad merged commit 52000d7 into master Dec 25, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the update/edit-post-shortcuts branch Dec 25, 2019
const formattingMethods = {
display: displayShortcut,
raw: rawShortcut,
ariaLabel: shortcutAriaLabel,
};
Comment on lines +43 to +47

This comment has been minimized.

Copy link
@aduth

aduth Jan 2, 2020

Member

Doubt it has much overhead, and I could grant an argument that it benefits from colocation, but this appears to be constant, could be defined at the top of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.