Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor KeyboardShortcuts component to rely on useKeyboardShortcut hook #19325

Merged
merged 3 commits into from Dec 25, 2019

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Dec 25, 2019

This PR refactors the KeyboardShortcuts component and the useShortcut hook to rely on the same useKeyboardShortcut hook. This allow us to only bundle mousetrap once in the compose package. Also, avoids code duplication.

@youknowriad youknowriad force-pushed the update/refactor-keyboard-shortcuts branch from 6ae223b to 539a812 Dec 25, 2019
@youknowriad youknowriad requested review from nerrad and ntwb as code owners Dec 25, 2019
@youknowriad youknowriad force-pushed the update/refactor-keyboard-shortcuts branch from 539a812 to f91da5a Dec 25, 2019
@youknowriad youknowriad force-pushed the update/refactor-keyboard-shortcuts branch from f91da5a to dc2d133 Dec 25, 2019
@youknowriad youknowriad merged commit 1f9d94a into master Dec 25, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the update/refactor-keyboard-shortcuts branch Dec 25, 2019
@marecar3 marecar3 mentioned this pull request Dec 25, 2019
2 of 2 tasks complete
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.