Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing button-block-appender icon on Firefox 71 and Safari 13 #19366

Conversation

@bartczyz
Copy link
Contributor

bartczyz commented Dec 30, 2019

Description

Fixes #19246

How has this been tested?

Manual testing using:

  • Firefox 71
  • Safari 13
  • Chrome 79

Screenshots

Before:
image

After:
image

Types of changes

Small style updates.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
outline: $border-width dashed $dark-gray-150;
width: 100%;
height: 100%;

This comment has been minimized.

Copy link
@youknowriad

youknowriad Jan 2, 2020

Contributor

I'm not sure about this rule as it's dependent on the parent element and this is a generic component, should this be auto instead of100%?

This comment has been minimized.

Copy link
@bartczyz

bartczyz Jan 2, 2020

Author Contributor

Yes, I agree! :)

I actually realised this after I opened the PR, but forgot to commit the update.

Copy link
Contributor

youknowriad left a comment

Thanks for the fix

@youknowriad youknowriad self-assigned this Jan 2, 2020
@youknowriad youknowriad merged commit 7b70c83 into WordPress:master Jan 2, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.