Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying not capitalizing the heading for each of the attributes #19374

Merged
merged 1 commit into from Jan 1, 2020

Conversation

@fabiankaegy
Copy link
Contributor

fabiankaegy commented Dec 31, 2019

Before changing this only parent, supports and all the supports children were using lowercase. All the other ones started with a capital letter. I think this should be unified, and because we are talking about attributes that are lowercase in the code I went with the lowercase option.

Before changing this only `parent`, `supports` and all the supports children were using lowercase. All the other ones started with a capital letter. I think this should be unified, and because we are talking about attributes that are lowercase in the code I went with the lowercase option.
@mkaz
mkaz approved these changes Jan 1, 2020
Copy link
Member

mkaz left a comment

👍

@mkaz mkaz merged commit 1b3516a into WordPress:master Jan 1, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.