Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalizing 'Manager' because Block Manager is a proper noun #19375

Merged
merged 2 commits into from Jan 1, 2020

Conversation

@mapk
Copy link
Contributor

mapk commented Dec 31, 2019

Description

Similarly to "Block Editor", the "Block Manager" is a proper noun and should be capitalized.

How has this been tested?

Tested locally.

Screenshots

Screen Shot 2019-12-31 at 11 32 23 AM

Types of changes

Non-breaking changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@mapk mapk requested a review from talldan as a code owner Dec 31, 2019
@mapk mapk self-assigned this Dec 31, 2019
@mapk mapk requested review from ajitbohra, nerrad and ntwb as code owners Jan 1, 2020
@mkaz
mkaz approved these changes Jan 1, 2020
Copy link
Member

mkaz left a comment

Looks good, 👍

Note, I needed to update the e2e-test that used the label, you can see my commit for an example on how.

@mkaz mkaz merged commit 504385a into master Jan 1, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mkaz mkaz deleted the update/block-manager-title branch Jan 1, 2020
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.