Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sentence case fixes for labels, etc. #19377

merged 5 commits into from Jan 4, 2020


Copy link

mapk commented Dec 31, 2019


This PR fixes more labels and copy to conform to Sentence case.

How has this been tested?

Tested locally.

Types of changes

Non-breaking changes.


  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@mapk mapk requested a review from talldan as a code owner Dec 31, 2019
@mapk mapk self-assigned this Dec 31, 2019
Copy link

mkaz left a comment

The changes look good. However, you'll need to update the tests to match the updated text. If you look at the details link from the Travis CI and click through each failing test it will show you each test and where it is failing.

@mapk mapk requested review from ajitbohra, nerrad and ntwb as code owners Jan 2, 2020
@mapk mapk requested a review from gziolo as a code owner Jan 3, 2020

This comment has been minimized.

Copy link

gziolo commented Jan 3, 2020

For reference, there is one failing unit test:
it has a corresponding snapshot saved which can be updated manually.

There are also 3 failing e2e tests for meta boxes:

It's quite possible that View Post is passed from PHP as this is something that depends on the post type.

@mapk mapk requested a review from mkaz Jan 3, 2020
mkaz approved these changes Jan 4, 2020
Copy link

mkaz left a comment


@mkaz mkaz merged commit 7a0e48c into master Jan 4, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
@mkaz mkaz deleted the update/more-sentence-case-fixes branch Jan 4, 2020
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.