Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WritingFlow: rewrite with hooks #19393

Merged
merged 2 commits into from Jan 3, 2020
Merged

WritingFlow: rewrite with hooks #19393

merged 2 commits into from Jan 3, 2020

Conversation

@ellatrix
Copy link
Member

ellatrix commented Jan 2, 2020

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@ellatrix ellatrix force-pushed the try/writing-flow-hooks branch from dbda254 to 3101c82 Jan 2, 2020
@ellatrix ellatrix merged commit fac293d into master Jan 3, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@ellatrix ellatrix deleted the try/writing-flow-hooks branch Jan 3, 2020
@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Jan 3, 2020

Do we expect any performance impact here?

@ellatrix

This comment has been minimized.

Copy link
Member Author

ellatrix commented Jan 3, 2020

@youknowriad Not really. I plan to refactor the component a bit though, and this makes it easier and it's a contained change.

@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.