Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Down Sprockets to v3.7.2 #152

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@tubbo
Copy link
Contributor

tubbo commented Oct 8, 2019

Sprockets v4.0 was released on 10/8/2019, which removed the
.register_engine method that is depended on by many extensions to
Sprockets at the current moment. Lock down Sprockets to v3.7.2 to avoid
these issues, which will show up when the app is loaded or tests are
run.

WORKAREA-18

Sprockets v4.0 was released on 10/8/2019, which removed the
`.register_engine` method that is depended on by many extensions to
Sprockets at the current moment. Lock down Sprockets to v3.7.2 to avoid
these issues, which will show up when the app is loaded or tests are
run.

WORKAREA-18
@tubbo tubbo requested review from bencrouse, jyucis, meowsus and mttdffy Oct 8, 2019
@bencrouse bencrouse merged commit e0e189d into v3.4-stable Oct 8, 2019
6 checks passed
6 checks passed
static_analysis
Details
admin_tests
Details
admin_system_tests
Details
core_tests
Details
storefront_tests
Details
storefront_system_tests
Details
@bencrouse bencrouse deleted the WORKAREA-18-lock-down-sprockets-to-v3 branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.