Skip to content

library: add SourceView example #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2023
Merged

library: add SourceView example #452

merged 4 commits into from
Aug 13, 2023

Conversation

@Cogitri
Copy link
Contributor

@Cogitri Cogitri commented Jul 29, 2023

Fixes #383

@Cogitri
Copy link
Contributor Author

Cogitri commented Jul 29, 2023

We currently can't instantiate the GtkSource.View directly in the blueprint since GtkSource.init() would have to be called before the builder loads the XML.

sonnyp
sonnyp approved these changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I really like the comments.

I made small improvements 0ab2be1

Sorry for the wait. It was great meeting you at GUADEC.

@sonnyp sonnyp merged commit 23c6de2 into workbenchdev:main Aug 13, 2023
sonnyp pushed a commit that referenced this pull request Aug 18, 2023
@Cogitri @sonnyp
library: add SourceView example (#452)
f52b3c7
sonnyp pushed a commit that referenced this pull request Aug 19, 2023
@Cogitri @sonnyp
library: add SourceView example (#452)
ecc8be7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sonnyp sonnyp sonnyp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SourceView library entry

2 participants

@Cogitri @sonnyp