library: add Breakpoint entry #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This entry is inspired by the C example found here. This kinda-sorta addresses #269, by changing the CSS classes of a label based on size. |
sonnyp
requested changes
Aug 13, 2023
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
I like it 👍
Simple but a good entry into breakpoints
| const image = workbench.builder.get_object("image"); | ||
|
|
||
| breakpoint.connect("apply", () => { | ||
| image.icon_size = Gtk.IconSize.NORMAL; |
Contributor
There was a problem hiding this comment.
I feel like we might as well do this in blueprint too and only do the console.log in Code
wdtyt?
| using Gtk 4.0; | ||
| using Adw 1; | ||
|
|
||
| Gtk.Window { |
Contributor
There was a problem hiding this comment.
should we have a title/subtitle like others demo?
We can also add a text that says "Resize the window to see the breakpoint effect"
Co-authored-by: Sonny Piers <sonny@fastmail.net>
sonnyp
approved these changes
Aug 13, 2023
sonnyp
pushed a commit
that referenced
this pull request
Aug 18, 2023
sonnyp
pushed a commit
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #407 and closes #269