library: Adds toolbarview entry #487
Conversation
Kooha-2023-08-15-20-13-43.webmP.S: the popovermenu bar doesn't seem to work somehow and gives a warning |
There was a problem hiding this comment.
This one needs a fair amount of cleanup to the UI.
The first thing I would do is move the boxed list and reveal buttons into the Adw.ToolbarView. The list rows labels also need to be updated to use labels following the HIG. Also it doesn't seem like any of the tab or view switchers work.
I'm thinking this one might need to be in a proper window, because the borders don't look quite right, and the close buttons actually try to close the Workbench window.
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Feedback from alice
why does the header bar have a GtkLabel in it?
| label:_("Header Bar"); | ||
| }; | ||
| } | ||
| content: Adw.StatusPage { |
There was a problem hiding this comment.
Switch this to an Adw.ViewStack
There was a problem hiding this comment.
Why? there is nothing to switch to
There was a problem hiding this comment.
Sorry, I'm confused now. I thought you wanted to demonstrate all the different bars? Unless I'm mistaken you need an Adw.ViewStack for the Adw.ViewSwitcherBar to work?
There was a problem hiding this comment.
Ah, I guess the idea is to have that other view switcher in the .blp file, along with the other widget? I guess I'm confused why not just actually use a view switcher?
There was a problem hiding this comment.
Kooha-2023-08-17-18-11-54.webm
@sonnyp @andyholmes Is this the kind of UI we wanted to achieve?
P.S: Yes, I'll get rid of those irrelevant viewstacks like account and notifications
|
Applied suggested changes
New issues:
|
* library: Port Event Controllers demo to Vala * library: Cast workbench.window when add_controller is called
* Adds Navigation View Entry * Minor Change * Applied Suggested Changes * Applied Changes * Applied Changes * Applied Changes
show off activatable widget
* library: Add Memory Monitor entry * Update main.json * Update main.blp * Memory Monitor: Suggestions
Closes #408