Add Bottom Sheet demo #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
reviewed
Oct 9, 2024
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Thanks!
BTW you've been added as a team member so you can create branches on the repo directly, you don't need to keep a fork
| Adw.SwitchRow { | ||
| active: bind bottom_sheet.open bidirectional; | ||
| title: "Open"; | ||
| } |
Contributor
There was a problem hiding this comment.
can you add a switch for https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/property.BottomSheet.reveal-bottom-bar.html ?
I believe opening the sheet programmatically without a handle is going to be a common use case.
Contributor
Author
There was a problem hiding this comment.
This property will be added in 1.7 so it can't land in 47. Maybe I can say somewhere that the bottom bar is optional
Contributor
Author
Thank you, I didn't know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185