add Gamepads demo #88
Open
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
reviewed
Mar 23, 2024
There was a problem hiding this comment.
Thanks for reopening
I made workbenchdev/Workbench#915 to explain to users how to add the --device=all or --device=input permission which we need before landing this.
Co-authored-by: Sonny <sonny@fastmail.net>
…into gamepads-demo
sonnyp
reviewed
Sep 26, 2024
| "category": "controls", | ||
| "description": "Respond to gamepads and controllers input", | ||
| "panels": ["code", "preview"], | ||
| "autorun": true |
There was a problem hiding this comment.
Suggested change
| "autorun": true | |
| "autorun": true, | |
| "flatpak-finish-args": ["--device=input"] |
Comment on lines
+8
to
+9
| title: _("Please connect a gamepad"); | ||
| description: _("A controller is needed for this demo"); |
There was a problem hiding this comment.
please use normal title/description from main.json and move the status/troubleshooting inside the status page
| Adw.StatusPage status_page { | ||
| title: _("Please connect a gamepad"); | ||
| description: _("A controller is needed for this demo"); | ||
| icon-name: "gamepad-symbolic"; |
There was a problem hiding this comment.
The icon is missing - please check the Library entry "Using Icons" on how to include one in the demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same demo from this pr with no manifest changes. It might need a little cleanup, haven't touched it in awhile.