From af1bed4c2bcd92edfb51621cfcc80e7a89fd7129 Mon Sep 17 00:00:00 2001 From: John Blischak Date: Tue, 29 Dec 2020 11:41:03 -0500 Subject: [PATCH] Require a minimum of R 3.3.0. https://github.com/workflowr/workflowr-pkg-tests/commit/454dfd6691c0edb2b60854a20bd94a73b1ca8e74 --- DESCRIPTION | 2 +- NEWS.md | 5 +++++ tests/testthat/test-wflow_publish.R | 11 +++-------- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 7a578672..cd2c87dc 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -33,7 +33,7 @@ Description: Provides a workflow for your analysis projects by combining URL: https://github.com/jdblischak/workflowr BugReports: https://github.com/jdblischak/workflowr/issues Depends: - R (>= 3.2.5) + R (>= 3.3.0) License: MIT + file LICENSE Encoding: UTF-8 LazyData: true diff --git a/NEWS.md b/NEWS.md index 555b8aa8..6c1afaef 100644 --- a/NEWS.md +++ b/NEWS.md @@ -53,6 +53,11 @@ load code defined in a `.Rprofile` file (idea from @pcarbo). syntax to insert icons into the navigation bar when a recent version of rmarkdown is installed (>= 2.6) (bug report from @christianholland, #231) +* Bump minimum required version of R from 3.2.5 to 3.3.0. While workflowr itself +should be able to continue to work fine with R 3.2.5, it was becoming too much +of a burden to regularly test workflowr with R 3.2.5 as the tidyverse team has +started updating their packages to require a minimum of R 3.3.0. + # workflowr 1.6.2 This patch release of workflowr includes minor improvements, updated diff --git a/tests/testthat/test-wflow_publish.R b/tests/testthat/test-wflow_publish.R index 6749fd80..2d51e751 100644 --- a/tests/testthat/test-wflow_publish.R +++ b/tests/testthat/test-wflow_publish.R @@ -342,14 +342,9 @@ test_that("wflow_publish restores previous docs/ if build fails", { md5sum_post <- tools::md5sum(html) mtime_post <- file.mtime(html) expect_identical(md5sum_post, md5sum_pre) - # expect_identical(mtime_post, mtime_pre) - # The test above failed R CMD check when testing with R 3.2.5. They aren't - # identical due too crazy small rounding errors: - # > mtime_post - mtime_pre - # Time differences in secs - # [1] -1.907349e-06 -9.536743e-07 -9.536743e-07 - # So instead I check with all.equal() and reduntantly with my own similiar - # test of the time difference (much less than the time it slept above). + expect_identical(mtime_post, mtime_pre) + # In case the above test fails due to rounding errors, the following tests + # ensure that the modification times are essentially identical. expect_equal(mtime_post, mtime_pre) expect_true(all(mtime_post - mtime_pre < 0.1)) })