Added error and test for overwrite = TRUE and existing = FALSE #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdblischak
requested changes
Apr 19, 2020
There was a problem hiding this comment.
@skpurdue This looks great! The CI builds are passing, and I tested locally as well. See above for my one minor request. After you update the test, I'll merge your PR.
Co-Authored-By: John Blischak <jdblischak@gmail.com>
jdblischak
approved these changes
Apr 19, 2020
|
@skpurdue Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To resolve issue #194, added error and test for when wflow_start() has overwrite = TRUE and existing = FALSE
Checklist
Details