Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable API Key #4

Merged
merged 3 commits into from May 10, 2019

Conversation

Projects
None yet
3 participants
@dewski
Copy link
Collaborator

commented May 3, 2019

This PR allows clients to configure the API key by using the WORKOS_API_KEY environment variable or through other means like secret managers.

Ideally this can be done using a configuration struct in the future when there is potentially more to configure, but for now keep it simple. It shouldn't require an API change should there be a configuration struct as the client will provide a default client it will set the API token to.

dewski added some commits May 3, 2019

@marktran

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

@sdalezman Would this work for your use case?

@sdalezman

This comment has been minimized.

Copy link

commented May 10, 2019

looks great!

@dewski dewski merged commit 76ce854 into master May 10, 2019

2 checks passed

Check code style The build passed on Semaphore 2.0.
Details
Run tests The build passed on Semaphore 2.0.
Details

@dewski dewski deleted the configurable-api-key branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.