Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename getProfile to getProfileAndToken #385

Merged
merged 2 commits into from May 11, 2021
Merged

Rename getProfile to getProfileAndToken #385

merged 2 commits into from May 11, 2021

Conversation

maxdeviant
Copy link
Contributor

This PR renames the getProfile method to getProfileAndToken.

This is a breaking change that will be part of v1.0.0.

Resolves SDK-154.

@maxdeviant maxdeviant self-assigned this May 11, 2021
@maxdeviant maxdeviant requested a review from a team as a code owner May 11, 2021 19:24
@linear
Copy link

linear bot commented May 11, 2021

SDK-154 Rename getProfile to getProfileAndToken in Node SDK

@maxdeviant maxdeviant merged commit dcd2143 into master May 11, 2021
@maxdeviant maxdeviant deleted the rename-get-profile-to-get-profile-and-token branch May 11, 2021 19:29
This was referenced May 12, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanjadvani rohanjadvani rohanjadvani approved these changes

Assignees

@maxdeviant maxdeviant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxdeviant @rohanjadvani