Update WorkOS PHP to v3.2.0 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheldonvaughn
requested review from
jonatascastro12
and removed request for
a team
sheldonvaughn
changed the title
sheldonvaughn
changed the title
added 9 commits
April 20, 2023 18:32
sheldonvaughn
changed the title
added 2 commits
April 20, 2023 20:02
maxdeviant
reviewed
Apr 20, 2023
| commands: | ||
| - bash bin/restore-cache-and-update-deps 7 | ||
| - composer run-script test | ||
| - composer run-script test |
There was a problem hiding this comment.
Do we need these changes here? Looks like just whitespace.
maxdeviant
reviewed
Apr 20, 2023
composer.json
Outdated
| "test": "php vendor/bin/phpunit tests" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we keep the newline at the end of the file?
maxdeviant
approved these changes
Apr 20, 2023
maxdeviant
left a comment
maxdeviant
left a comment
There was a problem hiding this comment.
A couple of minor comments, but otherwise LGTM
added 2 commits
April 20, 2023 23:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.