From e522e26af6643c11d26d3b827fc5003c2a6a9f4b Mon Sep 17 00:00:00 2001 From: Rohan Jadvani Date: Wed, 13 May 2020 12:34:30 -0400 Subject: [PATCH] Fix enum to string conversion in `get_authorization_url` --- tests/test_sso.py | 4 ++-- workos/sso.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test_sso.py b/tests/test_sso.py index d205b9b7..2a19131f 100644 --- a/tests/test_sso.py +++ b/tests/test_sso.py @@ -80,7 +80,7 @@ def test_authorization_url_has_expected_query_params_with_provider(self): parsed_url = urlparse(authorization_url) assert dict(parse_qsl(parsed_url.query)) == { - "provider": str(self.provider), + "provider": str(self.provider.value), "client_id": workos.project_id, "redirect_uri": self.redirect_uri, "response_type": RESPONSE_TYPE_CODE, @@ -116,7 +116,7 @@ def test_authorization_url_has_expected_query_params_with_domain_and_provider(se assert dict(parse_qsl(parsed_url.query)) == { "domain": self.customer_domain, - "provider": str(self.provider), + "provider": str(self.provider.value), "client_id": workos.project_id, "redirect_uri": self.redirect_uri, "response_type": RESPONSE_TYPE_CODE, diff --git a/workos/sso.py b/workos/sso.py index 8e119de1..9beaa21b 100644 --- a/workos/sso.py +++ b/workos/sso.py @@ -44,7 +44,7 @@ def get_authorization_url( redirect_uri (str) - A valid redirect URI, as specified on WorkOS state (dict) - A dict passed to WorkOS, that'd be preserved through the authentication workflow, passed back as a query parameter - provider (str) - Authentication service provider descriptor + provider (ConnectionType) - Authentication service provider descriptor Returns: str: URL to redirect a User to to begin the OAuth workflow with WorkOS @@ -62,7 +62,7 @@ def get_authorization_url( if provider is not None: if not isinstance(provider, ConnectionType): raise ValueError("'provider' must be of type ConnectionType") - params["provider"] = str(provider) + params["provider"] = str(provider.value) if domain is not None: params["domain"] = domain