Skip to content

Fix enum to string conversion in get_authorization_url #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanjadvani merged 1 commit into from
May 13, 2020
Merged

Fix enum to string conversion in get_authorization_url #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_sso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def test_authorization_url_has_expected_query_params_with_provider(self):
parsed_url = urlparse(authorization_url)

assert dict(parse_qsl(parsed_url.query)) == {
"provider": str(self.provider),
"provider": str(self.provider.value),
"client_id": workos.project_id,
"redirect_uri": self.redirect_uri,
"response_type": RESPONSE_TYPE_CODE,
Expand Down Expand Up @@ -116,7 +116,7 @@ def test_authorization_url_has_expected_query_params_with_domain_and_provider(se

assert dict(parse_qsl(parsed_url.query)) == {
"domain": self.customer_domain,
"provider": str(self.provider),
"provider": str(self.provider.value),
"client_id": workos.project_id,
"redirect_uri": self.redirect_uri,
"response_type": RESPONSE_TYPE_CODE,
Expand Down
4 changes: 2 additions & 2 deletions workos/sso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def get_authorization_url(
redirect_uri (str) - A valid redirect URI, as specified on WorkOS
state (dict) - A dict passed to WorkOS, that'd be preserved through the authentication workflow, passed
back as a query parameter
provider (str) - Authentication service provider descriptor
provider (ConnectionType) - Authentication service provider descriptor

Returns:
str: URL to redirect a User to to begin the OAuth workflow with WorkOS
Expand All @@ -62,7 +62,7 @@ def get_authorization_url(
if provider is not None:
if not isinstance(provider, ConnectionType):
raise ValueError("'provider' must be of type ConnectionType")
params["provider"] = str(provider)
params["provider"] = str(provider.value)
if domain is not None:
params["domain"] = domain

Expand Down