New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution checker just checks output #196

Open
AnshulMalik opened this Issue May 23, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@AnshulMalik
Member

AnshulMalik commented May 23, 2017

With out current implementation, we check the solution by comparing the output of solution program with expected, it has many issues, since same output can be generated in lot of ways.

We'd want to have some rigid solution checker which can check

  • Variable is declared or not
  • Any variable's value at any line (Deal with scopes)
  • Function is declared or not
  • Function's parameters

Here we want to observe the value of for loop's local variable i over iterations.

We can have discussion on how we can implement this and land a basic version.

@itzsaga

This comment has been minimized.

Show comment
Hide comment
@itzsaga

itzsaga May 23, 2017

Member

Jasmine?

Member

itzsaga commented May 23, 2017

Jasmine?

@AnshulMalik

This comment has been minimized.

Show comment
Hide comment
@AnshulMalik

AnshulMalik May 23, 2017

Member

We can use it as a candidate 👍 , but I don't know whether jasmine provide this feature to evaluate values of variables.
May be you can do some digging into jasmine to see whether it can do what we want ?

Member

AnshulMalik commented May 23, 2017

We can use it as a candidate 👍 , but I don't know whether jasmine provide this feature to evaluate values of variables.
May be you can do some digging into jasmine to see whether it can do what we want ?

@itzsaga

This comment has been minimized.

Show comment
Hide comment
@itzsaga

itzsaga May 23, 2017

Member

Will do. 👍

Member

itzsaga commented May 23, 2017

Will do. 👍

@itzsaga

This comment has been minimized.

Show comment
Hide comment
@itzsaga

itzsaga Jun 2, 2017

Member

@bsommardahl showed me how to solve our testing problem today in Jest. See https://gist.github.com/bsommardahl/da8251512a0a72facca9c12aea4bdb7b
I think this is a solid option for consideration.

Member

itzsaga commented Jun 2, 2017

@bsommardahl showed me how to solve our testing problem today in Jest. See https://gist.github.com/bsommardahl/da8251512a0a72facca9c12aea4bdb7b
I think this is a solid option for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment