Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basics get #96

Closed
emilefyon opened this issue Feb 11, 2017 · 1 comment
Closed

Basics get #96

emilefyon opened this issue Feb 11, 2017 · 1 comment

Comments

@emilefyon
Copy link

emilefyon commented Feb 11, 2017

module.exports = function (databaseDir, callback) {  
       var result = []  
       // your code...  
       result.push()  
       // more code...  
       callback(result)  
     } 

Should be :

module.exports = function (databaseDir, callback) {  
       var result = []  
       // your code...  
       result.push()  
       // more code...  
       callback(err, result)  
     } 

For sake of clarity, I would also add

The store will contain up to 10 entries with keys in the form:
key[X]
Where '[X]' is an integer between 0 and 100.

The store will contain up to 10 entries with keys in the form:
key[X]
Where '[X]' is an integer between 0 and 100. Keys are key1, key2, key3, etc.

Took me a loooooong time to get it and I had to review solutions from past version...

But thanks for the work ! Interesting ;)

@martinheidegger
Copy link
Contributor

Fixed in 00dc8c9, follow workshopper/org#35 to get updated about the deployment of v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants