Added the ability to cycle between monitors#163
Merged
Conversation
N1x0
requested changes
Jan 23, 2021
N1x0
left a comment
Contributor
There was a problem hiding this comment.
Hi @OldKros, nice PR!
I'm doing some testing at the moment and it seems to work well and quite frankly I feel like this could not only extend the current way of handling monitor interaction but actually replace in part, at least for focusing monitors. For moving windows to other monitors I believe it makes sense to retain the original approach as well. Just my two cents, it depends on what @rickbutton thinks in the end.
What's missing is adding these actions to the KeybindManager as default subscriptions. E.g.
Subscribe(mod | KeyModifiers.LShift, Keys.Right
() => _context.Workspaces.SwitchFocusToNextMonitor(), "Focus next monitor");
Subscribe(mod | KeyModifiers.LShift, Keys.Left
() => _context.Workspaces.SwitchFocusToPreviousMonitor(), "Focus previous monitor");
Subscribe(mod | KeyModifiers.Control, Keys.Right
() => _context.Workspaces.MoveFocusedWindowToNextMonitor(), "move focused window to next monitor");
Subscribe(mod | KeyModifiers.Control, Keys.Left
() => _context.Workspaces.MoveFocusedWindowToPreviousMonitor(), "move focused window to previous monitor");Potentially some more minor cleanups but other than that a great addition IMO!
N1x0
approved these changes
Feb 19, 2021
josteink
approved these changes
Feb 19, 2021
Member
|
Yeah this looks good to me to. Sorry about taking so long time getting this reviewed. Consider it merged! |
dalyIsaac
added a commit
to dalyIsaac/workspacer
that referenced
this pull request
Feb 19, 2021
Added the ability to cycle between monitors (workspacer#163)
dlundgaard
pushed a commit
to dlundgaard/workspacer
that referenced
this pull request
Feb 21, 2021
…t with those recently defined in workspacer#163 added `int GetWorkspaceIndex(IWorkspace workspace)` to the `IWorkspaceContainer` as suggested by @dalyIsaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the swapping between monitors with dedicated keybinds for each monitor rather annoying and instead wanted one keybind to go to the next monitor (or another to go to the previous) however that ability was not implemented. It was for the workspaces but not for monitors which I thought was a bit weird, so here we are.