Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title change event to prevent flickering in some apps #178

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

lvlts
Copy link
Contributor

@lvlts lvlts commented Feb 10, 2021

This PR removes the (so far) unused TITLE CHANGE event, which was causing flickering effects on several apps (editors):

  • Notepad
  • JetBrains products (in particular, the text editing window)
  • Some Sun AWT based products

Note: this is not a complete fix for JetBrains issues (#61) or Sun AWT. However, it makes the IDE and other applications very usable, with the additional filter added in your configuration (in particular, for dropdowns, menus and other floating windows in Sun AWT):

    context.WindowRouter.AddFilter((window) => !window.Class.Contains("SunAwtWindow"));

@lvlts lvlts force-pushed the remove-titlechange-event branch from b3cb165 to fd2e46c Compare February 10, 2021 22:20
@josteink
Copy link
Member

Good job. Looks good to me :)

@josteink josteink merged commit 0aaff44 into workspacer:master Feb 11, 2021
@josteink
Copy link
Member

with the additional filter added in your configuration (in particular, for dropdowns, menus and other floating windows in Sun AWT)

Would it make sense to add that as a default-filter to make this more usable out of the box?

Maybe you could send a PR for that too? 😃

lvlts added a commit to lvlts/workspacer that referenced this pull request Feb 14, 2021
removes title change event to prevent flickering in some apps (workspacer#178)
@lvlts lvlts deleted the remove-titlechange-event branch February 14, 2021 15:26
@lvlts lvlts mentioned this pull request Feb 14, 2021
@dalyIsaac dalyIsaac added this to the 0.9.11 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants