Fixes wrong workspace for window after restarting.#183
Merged
Conversation
Reproduction: - Let there be 3 workspaces. - Open Notepad on the 2nd workspace. - Switch back to the first workspace. - Restart workspacer. Expected behavior: Notepad opens on the 2nd workspace. Actual behavior: Notepad opens on the 3rd workspace. This occurs because `StickyWorkspaceContainer._workspaces` is mutated in `StickyWorkspaceContainer.AssignWorkspaceToMonitor`. https://github.com/rickbutton/workspacer/blob/0aaff4437222e471ea0ffd282b948a9dfb8b7ff5/src/workspacer.Shared/Workspace/StickyWorkspaceContainer.cs#L112-L113
N1x0
approved these changes
Feb 19, 2021
N1x0
left a comment
N1x0
left a comment
Contributor
There was a problem hiding this comment.
Tested and works just as intended from what I can tell. Very nice fix to a long-standing bug,
Thanks a lot!
rickbutton
approved these changes
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction:
Let there be 3 workspaces.
Expected behavior:
Notepad opens on the 2nd workspace.
Actual behavior:
Notepad opens on the 3rd workspace.
Diagnosis
This occurs because
StickyWorkspaceContainer._workspacesis mutated inStickyWorkspaceContainer.AssignWorkspaceToMonitor.https://github.com/rickbutton/workspacer/blob/0aaff4437222e471ea0ffd282b948a9dfb8b7ff5/src/workspacer.Shared/Workspace/StickyWorkspaceContainer.cs#L112-L113