ShowKeybindDialog now renders a table.#188
Conversation
- Added `KeyValueTable` - `GetKeybindString` capitalizes keys - `GetKeybindString` adds support for `KeyModifiers.Win`
|
I like the change and the addition of search functionality is very nice! Tested it and all key binds show and search works for both the description as well as the shortcuts. One issue however, is that if you open the dialog once and then close it you will run into an "object disposed" error if you try to open it again. I'd either include some error handling for this or change the way the KeyValueTable gets disposed. If you can fix this it'd be a fantastic change IMO. Thanks for the PR |
|
Thanks for pointing out that error - it should be fixed now. |
N1x0
left a comment
There was a problem hiding this comment.
The fix for for the KeyValueTable works as intended. Would like to add 1 minor change to the regex but other than that all looks good!
N1x0
left a comment
There was a problem hiding this comment.
All good! Will have to wait for @josteink or @rickbutton for the merge though
josteink
left a comment
There was a problem hiding this comment.
That's awesome. Thanks for the patch!
This adds
KeyValueTable, which is used to replaceTextBlockMessagefor displaying the current keybindings.Changes:
KeyValueTableCapitalizestring extension methodGetKeybindStringcapitalizes keys to aid readabilityGetKeybindStringadds support forKeyModifiers.Win