-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gaps plugin. #193
Added gaps plugin. #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested actually running this, but I have no objections to the code-form as is.
LGTM.
@rickbutton : It seems you will have to sign off this PR, if we are to get it merged 😄 |
Any updates on this PR? |
I would suggest building this yourself from dalyIsaac's fork as rickbutton has been missing for a while. See /scripts/buildandinstall.ps1 |
At this point I might just suggest creating a community fork. Just create a Github workspacer-organisation and take it from there. And feel free to invite @rickbutton too, if he at some point in the future decides to return from his absence 🙂 |
I have no experience creating or maintaining a github org, but I have a couple of PR's I will submit if someone makes a community fork. |
Fork discussed in this issue: #211 |
Can anyone else review and approve this PR? It needs one more approval. |
Thanks for the review. To enable merging it needs to be done by someone with write-access though. 😃 |
This PR adds the ability to customize the gap between windows. This takes the form of the "outer" gap, and the "inner" gap.
This PR tries to account for @rickbutton's comment in #161 (comment) by implementing a plugin using
IConfigContext::AddLayoutProxy
.Currently, the gap size is global - i.e., changing the gap in one workspace changes the gap in all workspaces. A local option can probably be added in the future, if so desired.
I've also added a sample snippet to
snippets/gaps.cs
.Related issues: #161 #95