Skip to content

Layout engines now ignore minimized windows#197

Merged
N1x0 merged 7 commits into
workspacer:masterfrom
dalyIsaac:minimize-windows
Jun 28, 2021
Merged

Layout engines now ignore minimized windows#197
N1x0 merged 7 commits into
workspacer:masterfrom
dalyIsaac:minimize-windows

Conversation

@dalyIsaac
Copy link
Copy Markdown
Member

@dalyIsaac dalyIsaac commented Mar 18, 2021

Resolves #72

@dalyIsaac dalyIsaac mentioned this pull request Mar 18, 2021
Closed
@josteink
Copy link
Copy Markdown
Member

josteink commented Mar 19, 2021

Given @rickbutton 's reply on the original issue:

So far this is intentional. Workspacer overrides the "minimize"/"show" actions of the default window manager. i.e. it will send a "show" message to a minimized window as soon as you click minimize.

... I guess this change should probably be enabled by a config-setting and not a hard-coded default like here.

@dalyIsaac
Copy link
Copy Markdown
Member Author

dalyIsaac commented Mar 20, 2021

I've updated it to so that IConfigContext has a Boolean CanMinimizeWindows. However, I'm not sure if this is the best place for it in the config.

The default behaviour is now to not allow minimizing.

@dalyIsaac dalyIsaac force-pushed the minimize-windows branch 2 times, most recently from c3dd38d to cdb2c93 Compare March 20, 2021 02:59
josteink
josteink approved these changes Mar 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@josteink josteink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@josteink
Copy link
Copy Markdown
Member

josteink commented Mar 23, 2021

@rickbutton What do you think about this PR as it looks now?

@josteink
Copy link
Copy Markdown
Member

josteink commented Jun 27, 2021

Can anyone else (with write-access) review and approve this PR? It needs one more approval.

N1x0
N1x0 reviewed Jun 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@N1x0 N1x0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, would only ask to also update the docs & default config file with the additional flag to make sure users are aware of it's existence.

N1x0
N1x0 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@N1x0 N1x0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@N1x0 N1x0 merged commit fd4fc7e into workspacer:master Jun 28, 2021
@dalyIsaac dalyIsaac deleted the minimize-windows branch June 28, 2021 04:31
@N1x0 N1x0 mentioned this pull request Jun 28, 2021
Closed
@dalyIsaac dalyIsaac added this to the 0.9.11 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josteink josteink josteink approved these changes

@N1x0 N1x0 N1x0 approved these changes

+2 more reviewers

@Julynx Julynx Julynx approved these changes

@JulioCabria JulioCabria JulioCabria approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.11

Development

Successfully merging this pull request may close these issues.

Unable to minimize windows

5 participants

@dalyIsaac @josteink @N1x0 @Julynx @JulioCabria