Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous workspace got wrong index fix #199

Merged

Conversation

nidhoggr-nil
Copy link
Contributor

Previous workspace looked at the wrong container, and got the wrong index, changing to the correct container, now gives the correct amount of workspaces, when looking at which index to switch to.

issue #198

…ndex, changing to the correct container, now gives the correct amount of workspaces, when looking at which index to switch to
Copy link
Member

@josteink josteink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@schiltz3 schiltz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josteink
Copy link
Member

PRs haven’t been merged in months and Rick haven’t been answering emails either.

Right now it seems a fork is needed to keep workspacer going forwards.

I’m discussing this in a issue here: #211. Feel free to let me know your thoughts.

@josteink
Copy link
Member

Can anyone else (with write-access) review and approve this PR? It needs one more approval.

Copy link
Member

@dalyIsaac dalyIsaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josteink josteink merged commit 7c24961 into workspacer:master Jun 27, 2021
@dalyIsaac dalyIsaac added this to the 0.9.11 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants