Skip to content

Fix description of alt-shift-/#205

Merged
dalyIsaac merged 3 commits intoworkspacer:masterfrom
tom-tan:fix-doc-of-ShowKeybindDialog
Jun 27, 2021
Merged

Fix description of alt-shift-/#205
dalyIsaac merged 3 commits intoworkspacer:masterfrom
tom-tan:fix-doc-of-ShowKeybindDialog

Conversation

@tom-tan
Copy link
Copy Markdown
Contributor

@tom-tan tom-tan commented May 10, 2021

This request fixes the description of keybind for alt-shift-/.
It is currently "open keybind window" but the actual behavior is to toggle the keybind window.

Note: this request accidentally includes unrelated change (in line 311-313) that fixes its newline code.
I could not remove this unrelated change from the commit when I made a commit with using my editor (VSCode) and code editor provided by Github website.

@josteink
Copy link
Copy Markdown
Member

PRs haven’t been merged in months and Rick haven’t been answering emails either.

Right now it seems a fork is needed to keep workspacer going forwards.

I’m discussing this in a issue here: #211

Feel free to let me know your thoughts.

Copy link
Copy Markdown
Member

@josteink josteink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Member

@dalyIsaac dalyIsaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dalyIsaac dalyIsaac merged commit 1f06e99 into workspacer:master Jun 27, 2021
@tom-tan tom-tan deleted the fix-doc-of-ShowKeybindDialog branch June 28, 2021 03:01
@dalyIsaac dalyIsaac added this to the 0.9.11 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants