Skip to content

Referenced template config, better AddBar example - #214

Merged
N1x0 merged 5 commits into
workspacer:masterfrom
wiredmatt:patch-1
Jun 27, 2021
Merged

N1x0 merged 5 commits into
workspacer:masterfrom
wiredmatt:patch-1

Conversation

@wiredmatt

@wiredmatt wiredmatt commented Jun 27, 2021 •

Copy link
Copy Markdown

Referenced template config file containing the #r directives (in my case the template file was never copied to %USERPROFILE%/.workspacer, may be a bug), so in case someone deleted the file or it didn't got generated like in my case know where to look for it.

Added a more complete example on how to use the AddBar function, it's not covered that for example Right/LeftWidgets expects a function.

Mateo Carriquí added 2 commits June 27, 2021 18:16
Added a more detailed example on how to use the AddBar function
Referenced template config file containing the #r directives (in my case the template file was never copied to %USERPROFILE%/.workspacer, may be a bug), so in case someone deleted the file or it didn't got generated like in my case they know where to look for it.
Comment thread docs/content/quickstart.md Resolved

@dalyIsaac dalyIsaac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wiredmatt

Copy link
Copy Markdown
Author

LGTM!

Nice :), I was thinking about adding a section showcasing users' custom configs like mine, in case someone prefers reading usable examples instead of the entire docs, which we'll of course sooner or later expand, but just so people can get started quickly using workspacer.

@dalyIsaac

Copy link
Copy Markdown
Member

I was thinking about adding a section showcasing users' custom configs like mine

Yeah that'd be awesome! My config is at https://github.com/dalyIsaac/workspacer-config/blob/main/workspacer.config.csx. It's a bit bloated - hopefully I can cut down on its size and merge some things into workspacer itself.

@wiredmatt

Copy link
Copy Markdown
Author

Your config is very useful, it'll be a great reference to link in the docs since it has everything a new user will be interested in. I'll make a new PR including this section I mentioned, if you know someone else that has their configs public we can reference them as well.

@N1x0 N1x0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@N1x0
N1x0 merged commit aab64c1 into workspacer:master Jun 27, 2021
@josteink

Copy link
Copy Markdown
Member

I was thinking about adding a section showcasing users' custom configs like mine

Couldn't we just use a wiki for that?

@N1x0

N1x0 commented Jun 28, 2021

Copy link
Copy Markdown
Contributor

I was thinking about adding a section showcasing users' custom configs like mine

Couldn't we just use a wiki for that?

@josteink Could and probably should! Can you enable the wiki for the repo?

@josteink

Copy link
Copy Markdown
Member

It's all yours, guys: https://github.com/workspacer/workspacer/wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants