Add configurable padding and focus text for some widgets#215
Conversation
Added Left and Right Padding to ActiveLayout and Workspace widget Added Focused and Unfocused fields to Active Monitor Widget
|
I like the ability to set padding, I'd just move it to IBarWidgetPart and then implement in the individual widgets as necessary. Also IMO defaults should not have any padding, I know this is up to personal preference, just stating mine. If you could make the necessary changes I'll approve them, thanks for the PR! |
|
I believe I made the changes you suggested. The default padding has been removed. I can add it back in if we think it is outside the scope of this PR. I did not change the Focus/Unfocus text, but I think it could be changed to the focus text being the text attribute, and hard coding unfocused to be an empty string. LMK what you think |
N1x0
left a comment
There was a problem hiding this comment.
Changes look good to me, I also agree that FocusedMonitorWidget should return something meaningful instead of just '****' or "", but I think that's better kept in a seperate PR. I will write something in the docs to reflect the change. Please have a look there as well as the author ;)
I may update the docs later with examples of how to use Extended Unicode with workspacer. With fonts like FontAwsome |
|
I love this PR because since day 1 I've always customized the padding (and needed to recompile workspacer everytime it updates). However, a padding set to an empty string ( padding.issues.mp4because of an inconsistency in line 88 of WorkspaceWidget.cs: If both padding variables are I would've liked to submit a fix myself, but I'm still not comfortable with Git and programming in general. |
Add attributes to the standard widgets allowing their text and padding to be modified in the config.
NOTE: The added attributes have default values corresponding to their original hard-coded values, so this is backward compatible.
1. Edit or remove padding characters around edges of widget elements:
Before:
After:
2. Change active monitor character and active layout padding
Before:
After: