Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docker builds #82

Merged
merged 1 commit into from Mar 17, 2020
Merged

chore: fix docker builds #82

merged 1 commit into from Mar 17, 2020

Conversation

@plrthink
Copy link
Contributor

plrthink commented Mar 16, 2020

No description provided.

Copy link
Member

why520crazy left a comment

Perfect

@why520crazy why520crazy merged commit db7f45b into worktile:master Mar 17, 2020
@why520crazy

This comment has been minimized.

Copy link
Member

why520crazy commented Mar 17, 2020

test this please

@plrthink

This comment has been minimized.

Copy link
Contributor Author

plrthink commented Mar 17, 2020

@why520crazy yeah, sure, I have done some tests before. Also, you can view it on Heroku https://ngx-planet-examples.herokuapp.com/about, which is built with docker.

@why520crazy

This comment has been minimized.

Copy link
Member

why520crazy commented Mar 18, 2020

@why520crazy yeah, sure, I have done some tests before. Also, you can view it on Heroku https://ngx-planet-examples.herokuapp.com/about, which is built with docker.

Good job, I haven't tests with docker before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.