From 0732d412c7b77c6b892473e0cc02f2df86117125 Mon Sep 17 00:00:00 2001
From: renjiez <renjiez@google.com>
Date: Tue, 21 Nov 2023 18:55:02 +0000
Subject: [PATCH] Rename protocol to HonestMajorityShareShuffle

---
 .../api/v2alpha/protocol_config.proto         | 20 +++++++++----------
 .../requisition_fulfillment_service.proto     | 15 +++++++-------
 2 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto b/src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto
index f368cbc12..f502134cb 100644
--- a/src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto
+++ b/src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto
@@ -201,10 +201,11 @@ message ProtocolConfig {
     NoiseMechanism noise_mechanism = 4;
   }
 
-  // Configuration for the Shuffle Based Secret Sharing Protocol.
-  message ShuffleBasedSecretSharing {
-    // Parameters for secret sharing sketches.
-    SecretSharingSketchParams sketch_params = 1
+  // Configuration for the Honest Majority Shuffle Based Secret Sharing
+  // Protocol.
+  message HonestMajorityShareShuffle {
+    // Parameters for honest majority shuffle sketches.
+    ShareShuffleSketchParams sketch_params = 1
         [(google.api.field_behavior) = REQUIRED];
 
     // The mechanism to generate noise by workers during the computation.
@@ -235,10 +236,8 @@ message ProtocolConfig {
       // RequisitionFulfillment/FulfillRequisition with an encrypted sketch.
       ReachOnlyLiquidLegionsV2 reach_only_liquid_legions_v2 = 3;
 
-      // Shuffle Based Secret Sharing protocol.
-      //
-      // Using honest-majority setting.
-      ShuffleBasedSecretSharing shuffle_based_secret_sharing = 4;
+      // Honest Majority Shuffle Based Secret Sharing protocol.
+      HonestMajorityShareShuffle honest_majority_share_shuffle = 4;
     }
   }
 
@@ -280,8 +279,9 @@ message ReachOnlyLiquidLegionsSketchParams {
   int64 max_size = 2 [(google.api.field_behavior) = REQUIRED];
 }
 
-// Parameters for a Shuffle Based Secret Sharing sketch.
-message SecretSharingSketchParams {
+// Sketch parameters for a Honest Majority Shuffle Based Secret Sharing
+// protocol.
+message ShareShuffleSketchParams {
   // The number of registers in the sketch.
   int64 register_count = 1;
 
diff --git a/src/main/proto/wfa/measurement/api/v2alpha/requisition_fulfillment_service.proto b/src/main/proto/wfa/measurement/api/v2alpha/requisition_fulfillment_service.proto
index b9fc53d0c..6c71c23fc 100644
--- a/src/main/proto/wfa/measurement/api/v2alpha/requisition_fulfillment_service.proto
+++ b/src/main/proto/wfa/measurement/api/v2alpha/requisition_fulfillment_service.proto
@@ -59,12 +59,13 @@ message FulfillRequisitionRequest {
 
     // The protocol config of the Computation. This is used to validate that
     // EDPs and the MPC are using the same protocol config.
-    // NOT required for LiquidLegionV2 protocol.
+    //
+    // NOT required for LiquidLegionV2 protocols.
     ProtocolConfig protocol_config = 4;
 
-    // Requisitions of ShuffleBasedSecretSharing protocol is fulfilled by either
-    // a blob or a seed.
-    message ShuffleBasedSecretSharing {
+    // Requisitions of HonestMajorityShareShuffle protocol is fulfilled by
+    // either a blob or a seed.
+    message HonestMajorityShareShuffle {
       // The seed can be expanded into a deterministic blob using the same PRNG.
       //
       // If the seed is not specified or empty, it means the requisition is
@@ -73,9 +74,9 @@ message FulfillRequisitionRequest {
     }
     // Protocol specified values.
     oneof protocol {
-      // Shuffle based secret sharing protocol. Fulfilled by either chunks (a
-      // blob), or a seed.
-      ShuffleBasedSecretSharing shuffle_based_secret_sharing = 5;
+      // Honest Majority Shuffle based secret sharing protocol. Fulfilled by
+      // either chunks (a blob), or a seed.
+      HonestMajorityShareShuffle honest_majority_share_shuffle = 5;
     }
   }