Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iebaltab: tweaks in t-test? #109

Closed
luizaandrade opened this issue Nov 27, 2017 · 2 comments
Closed

iebaltab: tweaks in t-test? #109

luizaandrade opened this issue Nov 27, 2017 · 2 comments
Labels
enhancement A new feature to be added to command resolved but not yet published Issue is fixed, but not yet published on SSC

Comments

@luizaandrade
Copy link
Member

about this comments discussion, should we

  1. make t-tests display optional?
  2. make it optional to display the normalized difference?
@bbdaniels
Copy link
Contributor

Here's the relevant Statalist thread and one of several citations:

screenshot 2017-11-27 10 26 59

@luizaandrade luizaandrade added the enhancement A new feature to be added to command label Feb 1, 2018
luizaandrade added a commit that referenced this issue Feb 14, 2018
@luizaandrade
first take at issue #109 -- STILL BUGGY
3fb6cfa
luizaandrade added a commit that referenced this issue Feb 14, 2018
@luizaandrade
Fixed bug in solution to issue #109
61d3232
@luizaandrade luizaandrade added the resolved but not yet published Issue is fixed, but not yet published on SSC label Feb 27, 2018
luizaandrade added a commit that referenced this issue Apr 9, 2018
@luizaandrade
Revert "first take at issue #109 -- STILL BUGGY"
b992568 
This reverts commit 3fb6cfa.

The issue in the display of row titles for t-tests and normalized differences reported in the review of the pull request (#128) is caused by the titles for the two being created in the same loop. I'm deleting only the part that generates the titles.
luizaandrade added a commit that referenced this issue Apr 11, 2018
@luizaandrade
iebaltab: added test regarding issue #109
d10ecfa 
If F-test for joint significance of balance variables is used, but neither the t-test or the normalized difference are displayed, then the columns for comparison between treatment arms are not created, and the F-test cannot be displayed.

This commit (1) displays an error message if option ftest is used along with nottest, and normdiff is not selected, (2) disables option ftest, (3) still creates the balance table.
@luizaandrade
Copy link
Member Author

This is now published in SSC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A new feature to be added to command resolved but not yet published Issue is fixed, but not yet published on SSC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbdaniels @luizaandrade