Permalink
Browse files

Use silent rules, and no-define

  • Loading branch information...
1 parent 5909a7c commit 355432ab20b8d4883c8728b2551363a67f8bb779 @alriddoch alriddoch committed Mar 21, 2012
Showing with 3 additions and 2 deletions.
  1. +1 −1 Eris/iround.h
  2. +2 −1 configure.ac
View
@@ -5,7 +5,7 @@
#ifndef ERIS_IROUND_H
#define ERIS_IROUND_H
-#ifndef PACKAGE
+#ifndef PACKAGE_NAME
#error iround.h must be included after config.h
#endif
View
@@ -11,7 +11,8 @@ AC_CANONICAL_HOST
dnl Automake setup
-AM_INIT_AUTOMAKE([nostdinc dist-bzip2 color-tests parallel-tests])
+AM_INIT_AUTOMAKE([nostdinc dist-bzip2 color-tests parallel-tests no-define silent-rules])
+AM_SILENT_RULES([yes])
dnl versioning info for libtool
ERIS_CURRENT=20

3 comments on commit 355432a

Owner

erikogenvik replied Mar 21, 2012

I have to ask why you've added all of these silent-rules? As I see it they have no benefit and only makes it harder to troubleshoot compilation issues.

Contributor

alriddoch replied Mar 21, 2012

It makes it way, way easier to spot spurious warnings that pop up, and is trivial to override using "make V=1".

Since I turned this on I've been picking up issues that generate warnings way more quickly.

Owner

erikogenvik replied Mar 21, 2012

Ah, I didn't know about "make V=1".

I never has had any problem with not seeing warnings, as Eclipse picks up all warnings and shows them in a nice view.

Please sign in to comment.