Remove reference to object_slot.h #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This header has been removed in newer versions of sigc++ and the removal causes a build failure for libwfut. Interestingly, the header file was essentially empty (at least in sigc++ version 2.4.1). Since it does not appear that this header served any useful function, the easiest solution seems to be to remove it. I was able to compile libwfut successfully without this line. If no one has any insight as to why this is included, I recommend that we remove it.
erikogenvik
added a commit
that referenced
this pull request
Nov 22, 2015
Remove reference to object_slot.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This header has been removed in newer versions of sigc++ and the removal causes a build failure for libwfut. Interestingly, the header file was essentially empty (at least in sigc++ version 2.4.1). Since it does not appear that this header served any useful function, the easiest solution seems to be to remove it. I was able to compile libwfut successfully without this line. If no one has any insight as to why this is included, I recommend that we remove it.