worldsayshi

  • Joined on
worldsayshi

I get js errors in console when trying to use it: Uncaught ReferenceError: startButton is not defined Uncaught ReferenceError: tabChanged is not de…

worldsayshi
worldsayshi
worldsayshi
Behaviors
33 commits with 1,143 additions and 1,283 deletions
worldsayshi

"replaced build suggestion params with one SuggestionParams parameter" - Felt good didn't it :)

worldsayshi

"removed unused classes" - Yay :D

worldsayshi

updateInterpreatations - typo

worldsayshi

'comparisionResult' doesn't really say much more than 'diff' - they are synonymous? What kind of diff is it?

worldsayshi

I found something interesting: In order to avoid using JSONService.buildSuggestionParams we should be able to simply use SuggestionParams as an arg…

worldsayshi
worldsayshi
worldsayshi

In buildSuggestion, getBestLinearization and SuggestionComparator.compare there are a lot of interesting things going on. See if there are ways to …

worldsayshi

(This is a nitpick and perhaps not needed) For this logic: if (word.startsWith(placeholderPrefix) && word.endsWith(placeholderSuffix)) { ... } Mayb…

worldsayshi

"lowWord" - Why not lowerCaseWord ? :)

worldsayshi

I’m adding some line breaks and fixing some typos on my end. Individually they seem to minor to comment on. As a general rule - and this is mostly …

worldsayshi

variable name diff in suggestioncomparator is a bit nondescriptive.

worldsayshi

If I type "Stockholm Java" in precision search gui tab I get an exception: ServletHandler:/api/precisionSearch/suggestSentences org.apache.solr.cli…

worldsayshi

No need to have an empty constructor in SuggestionParams

worldsayshi

I don't think we will gain much by having ContinueHint as a configurable property. At least not in that way. We could remove it for now.

worldsayshi

In the while loop in createSuggestionsForLinearization there is an integer 'index'. It seems that we can just use suggestions.size()? If they are s…

worldsayshi

LinkedList is used here and there. ArrayList is for most cases a better implementation. I'd say we should switch to that.

worldsayshi

The SuggestionBehavior constructor could use the EnumSet trick that you used in the previous pull request. I think it would be clearer that way.

worldsayshi

Also: "From" -> "From Bli to Bli", ... (repeated names)

worldsayshi

Vasttrafik: Asking for completions on "From" gives us many grammatical variations but no variations on names. I think we should have name variation…

worldsayshi

You should be able to debug using the GUI now. Merge the merge_refactor branch onto this one if you want to see result list as well.

worldsayshi

Here are some problematic things I see when looking at the behavior of 'precision search' completion. I'm not sure how these remarks relate to the …