Added username flickrOption in .search() method to support search within specified flickr user #223

Open
wants to merge 2 commits into
from

Projects

None yet

2 participants

@abhiomkar

Hi,

I just added username flickrOption in .search() method to support search within specified flickr user. By this feature, we can get specific flickr user's interesting photos in galleria.

I've also updated the Docs accordingly. Please let me know if the changes looks ok.

Cheers,
Abhinay

@davidhellsing

This looks pretty good, but I’m not sure how I feel about adding an option that only applies for one API call... any thoughts on that?

Owner

Thanks David! Yes, this option applies to only .search() method. Even if we provide username option to .user() method, it'll be ignored.

Sadly, flickr.people.getPublicPhotos doesn't support sort option. This change can also serve as alternative to flickr.people.getPublicPhotos in interestingness descending order.

Owner

Hello David, any thoughts on this yet?

@davidhellsing
Contributor

This is pretty handy, but I think we should supply a separate API call for this instead of using an option that only applies for a single API call. Ideas?

@abhiomkar

Hey David, I've added interestingness-desc and interestingness-asc sort option support to .user() method. And also with the previous commit the user should be able to search the photos with the given phrase and username options.

So, by default .user() method shows the user's public photos in interestingness-desc order as per the default options of galleria flickr plugin.

please have a look at the changes and let me know what do you think.

@abhiomkar

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment